fix(channels): avoid expanding advanced settings for model mapping
- remove model mapping from advanced settings error detection so visible model configuration errors do not expand the advanced panel. - update the edit-time advanced settings auto-expand check to only depend on fields actually rendered in the advanced section. - add regression coverage to verify model_mapping errors are not classified as advanced settings errors.
This commit is contained in:
@@ -49,6 +49,17 @@ describe('channel form errors', () => {
|
||||
assert.equal(hasAdvancedSettingsErrors(errors), false)
|
||||
})
|
||||
|
||||
test('does not treat model mapping errors as advanced settings errors', () => {
|
||||
const errors = {
|
||||
model_mapping: {
|
||||
type: 'custom',
|
||||
message: 'Invalid model mapping',
|
||||
},
|
||||
} satisfies FieldErrors<ChannelFormValues>
|
||||
|
||||
assert.equal(hasAdvancedSettingsErrors(errors), false)
|
||||
})
|
||||
|
||||
test('classifies schema errors from invalid advanced JSON fields', () => {
|
||||
const result = channelFormSchema.safeParse({
|
||||
...CHANNEL_FORM_DEFAULT_VALUES,
|
||||
|
||||
Reference in New Issue
Block a user