fix(channels): reveal advanced validation errors
- add channel form error detection for JSON validation errors inside advanced settings. - expand advanced settings on invalid channel drawer submit and prompt users to fix highlighted fields. - add regression tests for advanced error detection, non-advanced exclusions, and schema error classification.
This commit is contained in:
+23
-12
@@ -24,7 +24,7 @@ import {
|
|||||||
useCallback,
|
useCallback,
|
||||||
useRef,
|
useRef,
|
||||||
} from 'react'
|
} from 'react'
|
||||||
import { useForm } from 'react-hook-form'
|
import { type SubmitErrorHandler, useForm } from 'react-hook-form'
|
||||||
import { zodResolver } from '@hookform/resolvers/zod'
|
import { zodResolver } from '@hookform/resolvers/zod'
|
||||||
import { useQuery, useQueryClient } from '@tanstack/react-query'
|
import { useQuery, useQueryClient } from '@tanstack/react-query'
|
||||||
import {
|
import {
|
||||||
@@ -140,6 +140,7 @@ import {
|
|||||||
hasModelConfigChanged,
|
hasModelConfigChanged,
|
||||||
findMissingModelsInMapping,
|
findMissingModelsInMapping,
|
||||||
validateModelMappingJson,
|
validateModelMappingJson,
|
||||||
|
hasAdvancedSettingsErrors,
|
||||||
} from '../../lib'
|
} from '../../lib'
|
||||||
import {
|
import {
|
||||||
collectInvalidStatusCodeEntries,
|
collectInvalidStatusCodeEntries,
|
||||||
@@ -1008,6 +1009,26 @@ export function ChannelMutateDrawer({
|
|||||||
]
|
]
|
||||||
)
|
)
|
||||||
|
|
||||||
|
const handleAdvancedSettingsOpenChange = useCallback((nextOpen: boolean) => {
|
||||||
|
setAdvancedSettingsOpen(nextOpen)
|
||||||
|
if (typeof window !== 'undefined') {
|
||||||
|
window.localStorage.setItem(
|
||||||
|
ADVANCED_SETTINGS_EXPANDED_KEY,
|
||||||
|
String(nextOpen)
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}, [])
|
||||||
|
|
||||||
|
const onInvalid: SubmitErrorHandler<ChannelFormValues> = useCallback(
|
||||||
|
(errors) => {
|
||||||
|
if (hasAdvancedSettingsErrors(errors)) {
|
||||||
|
handleAdvancedSettingsOpenChange(true)
|
||||||
|
}
|
||||||
|
toast.error(t('Please fix the highlighted fields before saving'))
|
||||||
|
},
|
||||||
|
[handleAdvancedSettingsOpenChange, t]
|
||||||
|
)
|
||||||
|
|
||||||
// Handle drawer close
|
// Handle drawer close
|
||||||
const handleOpenChange = useCallback(
|
const handleOpenChange = useCallback(
|
||||||
(v: boolean) => {
|
(v: boolean) => {
|
||||||
@@ -1020,16 +1041,6 @@ export function ChannelMutateDrawer({
|
|||||||
[onOpenChange, form]
|
[onOpenChange, form]
|
||||||
)
|
)
|
||||||
|
|
||||||
const handleAdvancedSettingsOpenChange = useCallback((nextOpen: boolean) => {
|
|
||||||
setAdvancedSettingsOpen(nextOpen)
|
|
||||||
if (typeof window !== 'undefined') {
|
|
||||||
window.localStorage.setItem(
|
|
||||||
ADVANCED_SETTINGS_EXPANDED_KEY,
|
|
||||||
String(nextOpen)
|
|
||||||
)
|
|
||||||
}
|
|
||||||
}, [])
|
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<>
|
<>
|
||||||
<Sheet open={open} onOpenChange={handleOpenChange}>
|
<Sheet open={open} onOpenChange={handleOpenChange}>
|
||||||
@@ -1060,7 +1071,7 @@ export function ChannelMutateDrawer({
|
|||||||
<Form {...form}>
|
<Form {...form}>
|
||||||
<form
|
<form
|
||||||
id='channel-form'
|
id='channel-form'
|
||||||
onSubmit={form.handleSubmit(onSubmit)}
|
onSubmit={form.handleSubmit(onSubmit, onInvalid)}
|
||||||
className={sideDrawerFormClassName('gap-5')}
|
className={sideDrawerFormClassName('gap-5')}
|
||||||
>
|
>
|
||||||
{isChannelDetailLoading ? (
|
{isChannelDetailLoading ? (
|
||||||
|
|||||||
@@ -0,0 +1,71 @@
|
|||||||
|
/*
|
||||||
|
Copyright (C) 2023-2026 QuantumNous
|
||||||
|
|
||||||
|
This program is free software: you can redistribute it and/or modify
|
||||||
|
it under the terms of the GNU Affero General Public License as
|
||||||
|
published by the Free Software Foundation, either version 3 of the
|
||||||
|
License, or (at your option) any later version.
|
||||||
|
|
||||||
|
This program is distributed in the hope that it will be useful,
|
||||||
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||||
|
GNU Affero General Public License for more details.
|
||||||
|
|
||||||
|
You should have received a copy of the GNU Affero General Public License
|
||||||
|
along with this program. If not, see <https://www.gnu.org/licenses/>.
|
||||||
|
|
||||||
|
For commercial licensing, please contact support@quantumnous.com
|
||||||
|
*/
|
||||||
|
import type { FieldErrors } from 'react-hook-form'
|
||||||
|
import assert from 'node:assert/strict'
|
||||||
|
import { describe, test } from 'node:test'
|
||||||
|
import {
|
||||||
|
CHANNEL_FORM_DEFAULT_VALUES,
|
||||||
|
channelFormSchema,
|
||||||
|
type ChannelFormValues,
|
||||||
|
} from './channel-form'
|
||||||
|
import { hasAdvancedSettingsErrors } from './channel-form-errors'
|
||||||
|
|
||||||
|
describe('channel form errors', () => {
|
||||||
|
test('detects validation errors in collapsed advanced JSON fields', () => {
|
||||||
|
const errors = {
|
||||||
|
param_override: {
|
||||||
|
type: 'custom',
|
||||||
|
message: 'Invalid JSON',
|
||||||
|
},
|
||||||
|
} satisfies FieldErrors<ChannelFormValues>
|
||||||
|
|
||||||
|
assert.equal(hasAdvancedSettingsErrors(errors), true)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('ignores validation errors outside advanced settings', () => {
|
||||||
|
const errors = {
|
||||||
|
name: {
|
||||||
|
type: 'too_small',
|
||||||
|
message: 'Name is required',
|
||||||
|
},
|
||||||
|
} satisfies FieldErrors<ChannelFormValues>
|
||||||
|
|
||||||
|
assert.equal(hasAdvancedSettingsErrors(errors), false)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('classifies schema errors from invalid advanced JSON fields', () => {
|
||||||
|
const result = channelFormSchema.safeParse({
|
||||||
|
...CHANNEL_FORM_DEFAULT_VALUES,
|
||||||
|
name: 'OpenAI',
|
||||||
|
type: 1,
|
||||||
|
key: 'sk-test',
|
||||||
|
models: 'gpt-4o',
|
||||||
|
group: ['default'],
|
||||||
|
param_override: '{',
|
||||||
|
})
|
||||||
|
|
||||||
|
assert.equal(result.success, false)
|
||||||
|
if (result.success) return
|
||||||
|
|
||||||
|
const errors = result.error.flatten().fieldErrors
|
||||||
|
|
||||||
|
assert.ok(errors.param_override?.length)
|
||||||
|
assert.equal(hasAdvancedSettingsErrors(errors), true)
|
||||||
|
})
|
||||||
|
})
|
||||||
@@ -0,0 +1,67 @@
|
|||||||
|
/*
|
||||||
|
Copyright (C) 2023-2026 QuantumNous
|
||||||
|
|
||||||
|
This program is free software: you can redistribute it and/or modify
|
||||||
|
it under the terms of the GNU Affero General Public License as
|
||||||
|
published by the Free Software Foundation, either version 3 of the
|
||||||
|
License, or (at your option) any later version.
|
||||||
|
|
||||||
|
This program is distributed in the hope that it will be useful,
|
||||||
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||||
|
GNU Affero General Public License for more details.
|
||||||
|
|
||||||
|
You should have received a copy of the GNU Affero General Public License
|
||||||
|
along with this program. If not, see <https://www.gnu.org/licenses/>.
|
||||||
|
|
||||||
|
For commercial licensing, please contact support@quantumnous.com
|
||||||
|
*/
|
||||||
|
import type { FieldPath } from 'react-hook-form'
|
||||||
|
import type { ChannelFormValues } from './channel-form'
|
||||||
|
|
||||||
|
type ChannelFormErrorMap = Partial<
|
||||||
|
Record<FieldPath<ChannelFormValues>, unknown>
|
||||||
|
>
|
||||||
|
|
||||||
|
const ADVANCED_SETTINGS_FIELDS = new Set<FieldPath<ChannelFormValues>>([
|
||||||
|
'priority',
|
||||||
|
'weight',
|
||||||
|
'test_model',
|
||||||
|
'auto_ban',
|
||||||
|
'tag',
|
||||||
|
'remark',
|
||||||
|
'model_mapping',
|
||||||
|
'param_override',
|
||||||
|
'header_override',
|
||||||
|
'status_code_mapping',
|
||||||
|
'force_format',
|
||||||
|
'thinking_to_content',
|
||||||
|
'pass_through_body_enabled',
|
||||||
|
'proxy',
|
||||||
|
'system_prompt',
|
||||||
|
'system_prompt_override',
|
||||||
|
'allow_service_tier',
|
||||||
|
'disable_store',
|
||||||
|
'allow_safety_identifier',
|
||||||
|
'allow_include_obfuscation',
|
||||||
|
'allow_inference_geo',
|
||||||
|
'allow_speed',
|
||||||
|
'claude_beta_query',
|
||||||
|
'upstream_model_update_check_enabled',
|
||||||
|
'upstream_model_update_auto_sync_enabled',
|
||||||
|
'upstream_model_update_ignored_models',
|
||||||
|
])
|
||||||
|
|
||||||
|
export function isAdvancedSettingsField(
|
||||||
|
fieldName: string
|
||||||
|
): fieldName is FieldPath<ChannelFormValues> {
|
||||||
|
return ADVANCED_SETTINGS_FIELDS.has(fieldName as FieldPath<ChannelFormValues>)
|
||||||
|
}
|
||||||
|
|
||||||
|
export function hasAdvancedSettingsErrors(
|
||||||
|
errors: ChannelFormErrorMap
|
||||||
|
): boolean {
|
||||||
|
return Object.keys(errors).some((fieldName) =>
|
||||||
|
isAdvancedSettingsField(fieldName)
|
||||||
|
)
|
||||||
|
}
|
||||||
@@ -18,6 +18,7 @@ For commercial licensing, please contact support@quantumnous.com
|
|||||||
*/
|
*/
|
||||||
// Re-export all library functions
|
// Re-export all library functions
|
||||||
export * from './channel-actions'
|
export * from './channel-actions'
|
||||||
|
export * from './channel-form-errors'
|
||||||
export * from './channel-form'
|
export * from './channel-form'
|
||||||
export * from './channel-type-config'
|
export * from './channel-type-config'
|
||||||
export * from './channel-utils'
|
export * from './channel-utils'
|
||||||
|
|||||||
Reference in New Issue
Block a user